-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug splitchain test case for new parser. #89
Projects
Comments
In parsemap.cpp, there was a FIXME that was missed, the key is here 204 else
205 {
206 /**
207 * we need to clone the graph from the LHS (old LHS)
208 * to the end point, then place the end kernels returned
209 * from the clone to the RHS end of this parse graph, and put the
210 * source kernels in the LHS (ones in the middle aren't accessible
211 * regardless, but adding them here will make them accessible
212 * through the graph.
213 */
214 //FIXME
215 auto *temporary_map( GraphTools::duplicateBetweenVertices( nullptr, /** temp **/
216 nullptr ) );
217
218 auto *cloned_kernel( destination_original->clone() );
219 updateKernels( &kernel, cloned_kernel );
220 parse_link_helper( &kernel, cloned_kernel );
221 add_to_lhs_group( cloned_kernel );
222 } TODO: need to examine graphtools duplicateGraph routines....they're new, make issues to build test cases for both and likely graphviz script to dump the graph for visual inspection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
splitchain test case fails with the following error:
Should be relatively quick to debug, leaving note for tomorrow.
The text was updated successfully, but these errors were encountered: