Add eslint and apply it's suggestions

Author: RafalWilinski

.eslintignore

@@ -0,0 +1,3 @@
+coverage
+examples
+src/public

.eslintrc.json

@@ -5,15 +5,15 @@
     "it": false,
     "beforeEach": false,
     "before": false,
-    "after": false
+    "after": false,
+    "Chart": false
   },
   "rules": {
     "import/no-extraneous-dependencies": [
-      "error",
-      {
+      "error", {
         "peerDependencies": true
       }
     ],
     "no-param-reassign": "off"
   }
-}
+}

circle.yml

@@ -3,6 +3,7 @@ machine:
     version: 4.0.0
 test:
   pre:
+    - npm run eslint
     - nvm install 6.9.1 && nvm use 6.9.1 && npm test
     - nvm use node && npm test
     - snyk test

index.js

@@ -1 +1 @@
-module.exports = require('./src/middleware-wrapper');
+module.exports = require('./src/middleware-wrapper');

package.json

@@ -51,11 +51,17 @@
     "test": "mocha --recursive",
     "snyk-protect": "snyk protect",
     "prepublish": "npm run snyk-protect",
-    "example": "cd examples && npm start"
+    "example": "cd examples && npm start",
+    "eslint": "eslint . --fix"
   },
   "devDependencies": {
     "bithound": "^1.7.0",
     "chai": "^3.5.0",
+    "eslint": "^3.9.1",
+    "eslint-config-airbnb": "^12.0.0",
+    "eslint-plugin-import": "^1.16.0",
+    "eslint-plugin-jsx-a11y": "^2.2.3",
+    "eslint-plugin-react": "^6.5.0",
     "istanbul": "^0.4.5",
     "mocha": "^3.0.2",
     "sinon": "^1.17.5",

src/helpers/on-headers-listener.js

@@ -1,14 +1,14 @@
 module.exports = (statusCode, startTime, spans) => {
   const diff = process.hrtime(startTime);
-  const responseTime = diff[0] * 1e3 + diff[1] * 1e-6;
+  const responseTime = ((diff[0] * 1e3) + diff[1]) * 1e-6;
   const category = Math.floor(statusCode / 100);
 
   spans.forEach((span) => {
     const last = span.responses[span.responses.length - 1];
-    if (last !== undefined && last.timestamp / 1000 + span.interval > Date.now() / 1000) {
-      last[category]++;
-      last.count++;
-      last.mean = last.mean + ((responseTime - last.mean) / last.count);
+    if (last !== undefined && (last.timestamp / 1000) + span.interval > Date.now() / 1000) {
+      last[category] += 1;
+      last.count += 1;
+      last.mean += ((responseTime - last.mean) / last.count);
     } else {
       span.responses.push({
         2: category === 2 ? 1 : 0,

src/helpers/socket-io-init.js

@@ -1,4 +1,5 @@
 /* eslint strict: "off" */
+
 'use strict';
 
 const socketIo = require('socket.io');
@@ -14,15 +15,15 @@ module.exports = (server, config) => {
       io = socketIo(server);
     }
 
-    io.on('connection', socket => {
+    io.on('connection', (socket) => {
       socket.emit('esm_start', config.spans);
       socket.on('esm_change', () => {
         socket.emit('esm_start', config.spans);
       });
     });
 
 
-    config.spans.forEach(span => {
+    config.spans.forEach((span) => {
       span.os = [];
       span.responses = [];
       const interval = setInterval(() => gatherOsMetrics(io, span), span.interval * 1000);

src/middleware-wrapper.js

@@ -23,7 +23,7 @@ const middlewareWrapper = (config) => {
     if (req.path === config.path) {
       res.send(renderedHtml);
     } else {
-      onHeaders(res, () => { onHeadersListener(res.statusCode, startTime, config.spans) });
+      onHeaders(res, () => { onHeadersListener(res.statusCode, startTime, config.spans); });
       next();
     }
   };

test/helpers/validate.spec.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-unused-expressions */
 const chai = require('chai');
 
 chai.should();
@@ -56,7 +57,7 @@ describe('helpers', () => {
     });
 
     describe('when config is valid', () => {
-      const customConfig = { title: 'Custom title', path: '/custom-path', spans: [{}, {}, {}], port: 9999, websocket: {} }
+      const customConfig = { title: 'Custom title', path: '/custom-path', spans: [{}, {}, {}], port: 9999, websocket: {} };
       const config = validate(customConfig);
 
       it(`then title === ${customConfig.title}`, () => {