Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install with Ipware #41

Open
andrewgy8 opened this issue Jul 20, 2022 · 0 comments
Open

Install with Ipware #41

andrewgy8 opened this issue Jul 20, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@andrewgy8
Copy link
Contributor

What do you all think about having a install procedure like:

pip install django-requestlogs[ipware]

which installs the optional dependency.

The project would still maintain the default way of installing pip install django-requestlogs

If desired, this should be as easy as adding

extras_require={"ipware": ["django-ipware"]}

to the setup.py.

@Raekkeri Raekkeri added the good first issue Good for newcomers label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants