Ansible fix #768
Ansible fix #768
Conversation
…he dependent repos.
|
add BRI experts for review @panpan0000 @PengTian0 @changev |
|
Ok I discovered a problem when deploying with these changes to Ubuntu 14.04. The ansible version for trusty is 1.5.4, and the git "recursive" option isn't available to until ansible 1.6. This means while it works fine when using it with Ubuntu 16.04 but not 14.04 (without backports). I haven't been able to find out how to tell git to NOT pull the submodules in the old ansible. Looking at options, don't approve yet. |
| @@ -1,46 +1,152 @@ | |||
| --- | |||
| # This role supports developers who want to pull code from one or more repositories forked into their github organization. | |||
There was a problem hiding this comment.
can you please write a usage guide on the top, to tell which parameters does this new playbook accept ?
- organization
- branch
- repos ?
| - ucs-service | ||
|
|
||
| - name: Reset to the branch specified | ||
| shell: git reset --hard {{ branch }} |
There was a problem hiding this comment.
I noticed this step is gone. although a brand new clone will ensure local HEAD aligns master HEAD, so I think this step is not necessary.. just raise this up in case you deleted by accident.
Not quite yet on 14.04 (ansible 1.5.1) but this version is better than what I had prevously committed.
|
Do not commit this PR yet. Still working out the problems with using on 14.04 that carries a really old version of Ansible. I feel it is worth having once this is fixed for build system flexibility. |
|
BUILD RackHD #460 : FAILURE BUILD RackHD #460 Error Logs ▼Test Name: setup_ipmi_obm Error Details: (404) Reason: Not Found HTTP response headers: HTTPHeaderDict({'Content-Length': '110', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"6e-UNQOnoYfyToTqhCwZDYSweL3NzY"', 'Date': 'Fri, 16 Jun 2017 14:59:52 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'}) HTTP response body: {"message":"No Catalogs Found for Source (bmc).","status":"404","UUID":"ea549c91-a28d-48cf-a89a-8e9b7efcaa57"}-------------------- >> begin captured logging << -------------------- |
|
BUILD RackHD #466 : FAILURE BUILD RackHD #466 Error Logs ▼Test Name: test_node_catalogs Error Details: Node catalog is empty! Stack Trace: Traceback (most recent call last): File "/usr/lib/python2.7/unittest/case.py", line 331, in run testMethod() File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest self._testFunc() File "/home/jenkins/workspace/RackHD/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func compatability.capture_type_error(s_func) File "/home/jenkins/workspace/RackHD/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error func() File "/home/jenkins/workspace/RackHD/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func func(test_case.state.get_state()) File "/home/jenkins/workspace/RackHD/RackHD/test/tests/api/v2_0/nodes_tests.py", line 255, in test_node_catalogs assert_not_equal(0, len(resp), message='Node catalog is empty!') File "/home/jenkins/workspace/RackHD/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/proboscis/asserts.py", line 151, in assert_not_equal raise ASSERTION_ERROR(message) AssertionError: Node catalog is empty!Test Name: setup_ipmi_obm -------------------- >> begin captured logging << -------------------- Test Name: test_catalogs Test Name: test_tag_create Stack Trace: Traceback (most recent call last): Test Name: get_sku_nodes Stack Trace: Traceback (most recent call last): Test Name: post_skupacks Stack Trace: Traceback (most recent call last): |
|
BUILD RackHD #705 : FAILURE |
|
BUILD RackHD #747 : FAILURE |
|
@michaelsteven is this PR still valid? if not, we could close it |
This enhancement allows a developer to specify an "organization" in addition to the branch variable. Previously the ansible role would only pull from the rackhd organization.
It is written so that a developer can fork only the repos they want to work on into their "organization" (i.e. http://www.githhub.com/michaelsteven - where michaelsteven is the organization).
The role now does a check to see if the repo exists in the specified organization, and if not it will fall back pull from the "rackhd". It also does a check to see if the branch exists, and if not it will fall back to use "master".
Also changed is the dependence on "submodules" is removed. It no longer needs them.