Merge pull request #83 from wendal/patch-1

BernardXiong · web-flow · commit 7677cf265472 · 2021-12-14T06:20:20.000+08:00
fix: webclient_header_fields_add miss va_end when error
diff --git a/src/webclient.c b/src/webclient.c
@@ -533,12 +533,12 @@ int webclient_header_fields_add(struct webclient_session *session, const char *f
     va_start(args, fmt);
     length = rt_vsnprintf(session->header->buffer + session->header->length,
             session->header->size - session->header->length, fmt, args);
+    va_end(args);
     if (length < 0)
     {
         LOG_E("add fields header data failed, return length(%d) error.", length);
         return -WEBCLIENT_ERROR;
     }
-    va_end(args);
 
     session->header->length += length;
 

Original file line number	Diff line number	Diff line change
`@@ -533,12 +533,12 @@ int webclient_header_fields_add(struct webclient_session session, const char f`
`533`	`533`	`va_start(args, fmt);`
`534`	`534`	`length = rt_vsnprintf(session->header->buffer + session->header->length,`
`535`	`535`	`session->header->size - session->header->length, fmt, args);`
	`536`	`+ va_end(args);`
`536`	`537`	`if (length < 0)`
`537`	`538`	`{`
`538`	`539`	`LOG_E("add fields header data failed, return length(%d) error.", length);`
`539`	`540`	`return -WEBCLIENT_ERROR;`
`540`	`541`	`}`
`541`		`- va_end(args);`
`542`	`542`
`543`	`543`	`session->header->length += length;`
`544`	`544`