Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Restructure the code to build a wheel and use importlib to embed non-python files #1874

Open
bioinfornatics opened this issue Jan 27, 2024 · 1 comment
Labels
change request A code change requested by external or internal stakeholders needs clarification This issue needs additional information before it can be properly addressed

Comments

@bioinfornatics
Copy link

bioinfornatics commented Jan 27, 2024

Suggestion Description

Dear Tensile Team,

I am reaching out to advocate for the structuring of code in the RocM ecosystem in alignment with Linux packaging conventions. This initiative is not merely a step towards enhancing the usability of RocM but is also a strategic move to significantly elevate its prominence and accessibility in the development community.

The RocM ecosystem, despite its powerful capabilities, is often perceived as challenging to deploy, particularly when adhering to Linux standards. This perception acts as a barrier, deterring potential adopters and limiting the ecosystem's reach and impact. By restructuring the code to facilitate packaging (creating wheel distributions, for instance), we can dismantle these barriers, simplifying the installation and deployment process.

Benefits of Structuring Code for Packaging:

  • Ease of Deployment: Structured and packaged code can be seamlessly integrated and deployed, making the RocM ecosystem more approachable for new and existing users.
  • Standard Compliance: Aligning with Linux packaging conventions enhances compatibility and reliability, fostering trust and wider acceptance within the Linux user base.
  • Community Engagement: A more accessible and user-friendly structure encourages community engagement, leading to more contributions, enhanced features, and robust support.
  • Enhanced Collaboration: Packaged code eases the process of collaboration, allowing developers to focus on innovation rather than grappling with deployment intricacies.

The pull request at #1870 serves as a testament to the community's acknowledgment and the initial steps towards this enhancement. It is an embodiment of the potential improvements that structured and packaged code can bring to the RocM ecosystem.

In conclusion, restructuring the code to support standard packaging conventions is not just an upgrade; it's a transformative step towards making the RocM ecosystem more robust, accessible, and future-proof. I am looking forward to your thoughts on this proposal and am eager to contribute to this positive change.

Best regards,

Operating System

No response

GPU

No response

ROCm Component

No response

@bstefanuk bstefanuk added the change request A code change requested by external or internal stakeholders label Aug 2, 2024
@bstefanuk
Copy link
Contributor

@bioinfornatics Thank you for submitting this issue, we appreciate your time and commitment to supporting the project and completely agree that improving the packaging of Tensile will help improve adoption of the ROCm ecosystem.

I've reviewed your associated PR where you mention you "would like to package ROCm software to industrialize [your] ROCm DeepLearning environment". We would be glad to support your adoption of ROCm!

Could you please clarify the exact nature of the change you would like to see? How are you integrating Tensile into your project? How are you packaging ROCm?

@bstefanuk bstefanuk added the needs clarification This issue needs additional information before it can be properly addressed label Aug 2, 2024
@bstefanuk bstefanuk changed the title [Feature]: Can we structure the code in order i) to build a wheel ii) to use importlib for embedded non python file [Feature]: Restructure the code to build a wheel and use importlib to embed non-python files Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change request A code change requested by external or internal stakeholders needs clarification This issue needs additional information before it can be properly addressed
Projects
None yet
Development

No branches or pull requests

2 participants