Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation]: Add information that building on Windows is not supported #3414

Open
ColorfulRhino opened this issue Feb 16, 2024 · 5 comments

Comments

@ColorfulRhino
Copy link

Description of errors

As per https://rocm.docs.amd.com/projects/install-on-windows/en/develop/conceptual/release-versioning.html#windows-builds-from-source building on Windows is not supported. Including this information in this repo's build docs would add to this information's visibility.

Attach any links, screenshots, or additional evidence you think will be helpful.

References:

"The windows release cycle differs from the linux release cycle. For more information, see https://rocm.docs.amd.com/projects/install-on-windows/en/develop/conceptual/release-versioning.html The list is not up to date with the linux releases, but currently 5.7 is the latest windows release, so rocm 6.0 is not officially supported on windows. @Sabrewarrior it is sadly not possible to build rocm for windows from source, as it is not completely open source"

Originally posted by @MKKnorr in ROCm/ROCm#2729 (reply in thread)

"@ColorfulShire I agree, that this information is not very visible. As for adding a note to the build documents, I can't really do much about that, but feel free to open an issue at https://github.com/ROCm/HIP or even a PR to its documentation"

Originally posted by @MKKnorr in ROCm/ROCm#2729 (reply in thread)

@ColorfulRhino
Copy link
Author

Pull request fixing this issue: #3416 (comment)

@harkgill-amd
Copy link

harkgill-amd commented Jul 2, 2024

Hi @ColorfulRhino, the repo structure has changed slightly since you opened #3416. I have created an internal ticket to update the documentation, thanks!

@ColorfulRhino
Copy link
Author

ColorfulRhino commented Jul 2, 2024

Hi @ColorfulRhino, the repo structure has changed slightly slightly since you opened #3416. I have created an internal ticket to update the documentation, thanks!

Thanks! I can also update the PR to point at the correct file. Please let me know if you prefer your internal solution, in that case the PR can be closed. @harkgill-amd

@harkgill-amd
Copy link

Let's go with the internal ticket for now. Please close the PR whenever you get a chance.

@ColorfulRhino
Copy link
Author

Let's go with the internal ticket for now. Please close the PR whenever you get a chance.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants