Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible dev and peer dependencies not detected #63

Open
steida opened this issue May 18, 2024 · 1 comment
Open

Incompatible dev and peer dependencies not detected #63

steida opened this issue May 18, 2024 · 1 comment

Comments

@steida
Copy link

steida commented May 18, 2024

Check @sqlite.org/sqlite-wasm. I forget to add caret, and it wasn't detected. Thank you for the fantastic checker.

"devDependencies": {
    "@evolu/common": "workspace:*",
    "@evolu/tsconfig": "workspace:*",
    "@sqlite.org/sqlite-wasm": "3.45.3-build2",
    "@types/web-locks-api": "^0.0.5",
    "eslint": "^8.57.0",
    "eslint-config-evolu": "workspace:*",
    "typescript": "^5.4.5",
    "user-agent-data-types": "^0.4.2",
    "vitest": "^1.6.0"
  },
  "peerDependencies": {
    "@evolu/common": "^5.1.2",
    "@sqlite.org/sqlite-wasm": "3.45.1-build2"
  },

evoluhq/evolu#405

@QuiiBz
Copy link
Owner

QuiiBz commented May 27, 2024

That might be hard to do. We removed the explicit versions check because of #61, but checking if the dependencies satisfy the peer dependencies correctly would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants