-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long proofs unable to load #229
Comments
have you saved the proof again or is this an old file? Can you attach the proof file here? |
It is the old file. I don't have the proof open. I saved it to update my OS. Below the file. I have changed the extension to .txt so that Github doesn't complain. |
But if you can tell me which version of zxlive I need to open this file, I'll pull an older version. I needed these diagrams tonight... |
ok let me try to debug and see if we can recover the proof from that file |
Isn't this just issue #207 (which was caused by PR #204)? I think PR #204 should be reverted. It's supposed to fix saving proofs with parametrized spiders, but it makes it so that proofs can't be loaded at all (as the vertices are erroneously mislabeled after the first proof step), which is arguably worse. As long as the proofs internally save the graphs as JSON rather than Tikz format, the saving/loading bug will happen. |
I guess ZXLive is pre-release or beta software so there's no guarantee that file formats won't change, but it would still be good if the changes are better documented and users given more warning about such changes. In PR #222, I added a test which makes it so that any PR which is backwards incompatible have to explicitly update the test. I think in general any PR which breaks backwards-compatibility should say so very clearly in the commit's message and PR description. In some other projects I've worked on, for example, there's a policy that the commit message for such changes should be, e.g., " |
As additional information: It's not about a change of file formats. I used the same version to save as I used to load and they were incompatible. |
Does this happen on the latest version? |
In particular, please make sure you have the latest version of both ZXLive and PyZX. In your |
I agree that we should better label backwards compatible changes. One way we could encourage this would be to use an PR template that asks whether the changes are backward compatible with a reminder to label them as so in the commit message. The reviewers can also verify the commit messages are appropriately labelled. The test you added is extremely useful! |
I'm in favour of reverting the change as well. JSON serialisation is pyxz doesn't preserve the ordering of vertices and I currently have no quick fix for it. Though it is something I intend of resolving in the short term, testing the change may prove to take up the most time |
@Aerylia Could you provide a screenshot of the proof or a simplified example? Since the file you provided can't be loaded, I don't know how to replicate the bug. |
We currently don't support this. Our logic for parameterised gates is very rudimentary. I have recorded this feature request in #232 |
I think we already support this though. If it doesn't work, then it must be some sort of bug |
Can you clarify this? Do you mean that you want the parameter to be some value |
I have created a bunch of long proofs and most of them are unable to load.
I get this message:
The number changes for different files.
No errors from the terminal.
I am on Macbook Air M1, MacOS Sonoma 14.2.1
The text was updated successfully, but these errors were encountered: