Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab border color doesn't change when installing custom themes #197

Closed
dreamsynth opened this issue May 19, 2024 · 4 comments
Closed

Tab border color doesn't change when installing custom themes #197

dreamsynth opened this issue May 19, 2024 · 4 comments

Comments

@dreamsynth
Copy link

dreamsynth commented May 19, 2024

Even though the custom theme has a yellow tab border color, the tab border color does not change when the theme is applied.

How it should be How it appears
изображение изображение

Firefox Dev 127.0b3
userChrome.Style.ThirdParty.Enabled
userChrome.Tabs.Option2.Enabled
userChrome.LightTheme.Tabs.Borders.Enabled
userChrome.DarkTheme.Tabs.Borders.Enabled

@QNetITQ
Copy link
Owner

QNetITQ commented May 19, 2024

I'm going to change the way tab borders are handled in v1.6.127. The old method is quite complicated, inflexible and does not work with translucent surfaces. This can be bypassed, but then there will be problems with compatibility with some themes from AMO. Just enable the key userChrome.Tabs.SelectedTabIndicator.Enabled.

@dreamsynth
Copy link
Author

Could you please tell if in the future it will be possible to show the selected tab indicator as a border like in the original Firefox theme?

@QNetITQ
Copy link
Owner

QNetITQ commented Jun 15, 2024

This is not easy to do and will require a lot of compromises. Most likely I won't even try.

@QNetITQ
Copy link
Owner

QNetITQ commented Sep 7, 2024

I made shadows compatible with AMO themes. As much as possible, given the limitations. Should work starting with v1.7.131.

@QNetITQ QNetITQ closed this as completed Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants