Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with solutions files #22

Open
c-cunningham opened this issue Nov 5, 2020 · 2 comments
Open

Issues with solutions files #22

c-cunningham opened this issue Nov 5, 2020 · 2 comments

Comments

@c-cunningham
Copy link
Contributor

The file solutions/check_normalized.py , referenced in module 1.5.2, doesn't seem to exist. There are some other issues with solutions as well. The solutions for the first exercise of 1.5.1 and the extended exercise of 1.6.4 didn't work for me. Also, some of the solutions files have queries as if they are early drafts still being written. It would be good to check that every solution file exists, is complete, and works with Python 3.
@armanschwarz
Copy link
Collaborator

Hey Connor, sorry if I missed it, but did you resolve some of this with your commits?

@c-cunningham
Copy link
Contributor Author

Hey Arman, as far as I can remember I haven't resolved any of this. For the most part I wasn't sure how to resolve it. I can look through again and see if there's anything I'm more able to resolve now that I have a few months of experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@armanschwarz @c-cunningham