Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book PDF related issues by Vuokko #153

Open
12 of 27 tasks
HTenkanen opened this issue Oct 3, 2023 · 0 comments
Open
12 of 27 tasks

Book PDF related issues by Vuokko #153

HTenkanen opened this issue Oct 3, 2023 · 0 comments

Comments

@HTenkanen
Copy link
Contributor

HTenkanen commented Oct 3, 2023

TABLE OF CONTENTS / I Python essentials:

  • Check "orphan" subheadings in section 1: 1.1.1; 1.6.1 and 4.4.1 - can we do without these or is there need for another subheading to accompany these lonely ones?
  • Check consistency of headings in Exercies-sections; Exercise 3 now takes a lot of space in the TOC because all Problem topics are visible

TABLE OF CONTENTS / II Introduction to GIS with Python

Check "orphan" subheadings in section 2 (if we can do without or if the section can have another subheading):

  • 6.7.1 How to check if point is inside a polygon? (ref. also in this todo card)
  • 6.8.1 Point in Polygon using Geopandas

Check lengthy/unclear headings:

  • 5.1.2 could be e.g. "Core libraries for geographic data analysis in Python"
  • 5.3.3 perhaps ok as such , but could be shortened as "Map projections"
  • 5.3.4 consider re-wording the title. Suggestions: "Coordinate Reference System formats" / "CRS formats" or "Storing Coordinate Reference System information"
  • 6.2.5 the verb "preparing" sounds a bit weird? Could it simply be "Reading different file formats"? or similar. The following titles
  • 6.2.6; 6.2.7 repeat "GeoDataFrame" , so now the TOC looks a bit redundant.

Other minor comments:

  • 6.10.1 --> "Joining the layers" (in stead of "join", to align with the style of other titles)
  • 6.10.3. vs 6.10.4. "Nearest Neighbour" vs "Nearest neighbor" (check also spelling in text)
  • 6.10.6 "Motivation" - Funny place for this title? - check section structure
  • 6.2.3 geopandas or 6.8.1 Geopandas (capitalized or not; check also text)

SECTION II layout notes:
(Page number refers to page number printed on the page in the latest PDF)

  • p.203 GeoJSON print out goes off page
  • p. 205 Figure 5.4 Raster data model. Font is super tiny, especially the raster cell values
  • p. 221 poly_with_hole POLYGON print stays on page, but goes off margin?
  • p. 230, section 6.2.5.3 Code related to reading zipfile goes off page. Same thing & similar code in 6.10.4.2 , p. 293 under Spatial join!
  • note the TODO-notes in 6.2.5.2 and 6.2.5.3, page 230!
  • p. 231, section 6.2.5.4; Error with writing KML
  • p. 234, section 6.2.6 pandas FutureWarning related to incompatible dtype
  • p.252, section 6.4.2 crs_object print goes off page, also crs_wkt print goes off page
  • p. 281, section 6.10.1 pop.crs print goes off page , same thing on the next page, different crs format
  • p. 277 6.10 NOTE: ADD IMAGE ABOUT THE BASIC IDEA OF SPATIAL JOIN!
  • 13 figures are missing captions!: Figures 6.27-6.30; Figures 6.32- 6.40; Figure 6.43
  • p 287, UserWarning related to join.to_file()
  • p. 287 6.10.3 Note: ADD IMAGE ABOUT THE BASIC IDEA OF NEAREST NEIGHBOR!
  • Section 6.10.4.2, p. 293 --> some code/comments go off page or off margin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant