Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: GitHub Workflows: macOS test always failed when os = "self-hosted" #864

Open
bact opened this issue Nov 13, 2023 · 5 comments
Open
Assignees
Labels
bug bugs in the library help wanted no contributor yet
Projects
Milestone

Comments

@bact
Copy link
Member

bact commented Nov 13, 2023

Description

macOS test config matrix.os = "self-hosted" always failed.

.github/workflows/macos-test.yml

Expected results

If nothing is wrong with the code itself, the test should pass.

Can compare this with the results from Windows, Linux, and macOS os = "macos-latest" test configs.

Current results

From one of the test, this is the result:

14: 51074 Killed: 9               python -m unittest discover
/Users/pythainlp/miniconda3/envs/pythainlp38/lib/python3.8/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: There appear to be 2 leaked semaphore objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
Error: Process completed with exit code 137.

See in full: https://github.com/PyThaiNLP/pythainlp/actions/runs/6847071857/job/18614686269?pr=862

Steps to reproduce

Commit any code that will trigger the unittest on GitHub workflow

PyThaiNLP version

dev latest

Python version

3.8

Operating system and version

macOS

More info

No response

Possible solution

No response

Files

.github/workflows/macos-test.yml

@bact bact added bug bugs in the library help wanted no contributor yet labels Nov 13, 2023
@bact bact added this to the 5.0 milestone Nov 13, 2023
@bact bact added this to To do in PyThaiNLP Nov 13, 2023
@konbraphat51
Copy link
Contributor

Isn’t Lint a problem too?

@wannaphong
Copy link
Member

I'm working on this problem. I have a problem. GitHub Actions can't work like containers.

It currently runs on a MacOS vm set up like MacOS, but without containers. I'm not sure what setup I should configure?

@wannaphong wannaphong self-assigned this Nov 13, 2023
@bact
Copy link
Member Author

bact commented Nov 14, 2023

How MacStadium get connected with GitHub Actions? Does it need a special hook or config? I may be able to take a look, but not sure where to start.

@wannaphong
Copy link
Member

wannaphong commented Nov 14, 2023

How MacStadium get connected with GitHub Actions? Does it need a special hook or config? I may be able to take a look, but not sure where to start.

It use github-hosted-runners. MacStadium host Mac mini M1 like normal computer that can access by ssh or vnc and It can connect internet. The runners can running any script (even rm -rf /), so I host a macOS's Virtual Machine in subsystem to secured.

Config: https://github.com/PyThaiNLP/pythainlp/blob/dev/.github/workflows/macos-test.yml

@bact
Copy link
Member Author

bact commented Nov 14, 2023

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs in the library help wanted no contributor yet
Projects
PyThaiNLP
  
To do
Development

No branches or pull requests

3 participants