You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
flake8 7 is out so pyproject.toml should probably change from "flake8 >= 6.0.0, < 7.0.0",
to "flake8 >= 6.0.0, < 8.0.0",
as the breaking changes in flake8==7.0.0 are pretty minor.
I would also consider removing the upper bound as well. Flake8 breaking changes are often pretty minor and often don't break anything to do with extensions. And each time there is a new flake8 version, it takes weeks for all the extensions to update their upper bounds for flake8.
Thanks for opening the issue! Yeah, I agree that upper bounds (like the one we have!) are in general bad and make things more painful for users -- sorry about that. Unfortunately, we've been pretty badly broken before by flake8 refactoring their internals (see #257). This is entirely our fault rather than flake8's -- we monkey-patch some flake8 internals in an unauthorised way -- but at the same time, it's hard to see how we could stop doing that monkeypatching while keeping our full feature set. So, unfortunately, I think we need to keep the upper bound here.
flake8 7 is out so pyproject.toml should probably change from
"flake8 >= 6.0.0, < 7.0.0",
to
"flake8 >= 6.0.0, < 8.0.0",
as the breaking changes in flake8==7.0.0 are pretty minor.
I would also consider removing the upper bound as well. Flake8 breaking changes are often pretty minor and often don't break anything to do with extensions. And each time there is a new flake8 version, it takes weeks for all the extensions to update their upper bounds for flake8.
https://iscinumpy.dev/post/bound-version-constraints/
The text was updated successfully, but these errors were encountered: