Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failed workflow banner is shown even if only extra tests failed #4

Open
orbeckst opened this issue Feb 18, 2022 · 0 comments
Open

failed workflow banner is shown even if only extra tests failed #4

orbeckst opened this issue Feb 18, 2022 · 0 comments

Comments

@orbeckst
Copy link
Contributor

If a test is marked as extra then failing this test will always fail the whole workflow and thus lead to a workflow banner that indicates failure.

This can confuse students who know that they don't need the extra work to get full points (and indeed, the point banner shows that they have NN/NN points).

Failing extra tests should not fail the whole workflow or at least the "passing" banner should be shown if all regular tests passed. See also #3 .
orbeckst added a commit that referenced this issue Feb 18, 2022
@orbeckst
README updates
fa4c17f 
- fix typo in README
- link to pyyaml
- removed "key" in list of keys
- corrected description of **extra** (see #4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orbeckst