Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in ProjectileManager #2988

Closed
wants to merge 5 commits into from

Conversation

RenderBr
Copy link

This is a very simple pull request. I have simply bulk renamed the class that was originally ProjectileManagager to ProjectileManager. This is minor, but I felt like it should be done.

ProjectileManagager => ProjectileManager
@hakusaro
Copy link
Member

Won’t this break any third party consumers of the ProjectileManagager?

@drunderscore
Copy link
Contributor

Yeah, this is both source and binary incompatible, can't rename it.
If it bothers you enough, I suppose this will have to do:

using ProjectileManager = ProjectileManagager;

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your very correct, there would have to be a change in all the plugins to support this, as this is hard to do by contacting all the plugin developers I believe that this should go unchanged...

@RenderBr
Copy link
Author

Fair enough, I didn't think about this. Feel free to close this PR.

@ghost
Copy link

ghost commented Oct 27, 2023

@RenderBr if you wish to close this then close the PR with the close button

@RenderBr RenderBr closed this Oct 27, 2023
@Arthri
Copy link
Contributor

Arthri commented Oct 27, 2023

For the record, I'm not against this PR, but it'll have to be delayed until the next major update to prevent unnecessary breaking changes in between feature versions

@Arthri Arthri reopened this Oct 27, 2023
@ghost
Copy link

ghost commented Nov 13, 2023

guess this is a major update thing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants