-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typo in ProjectileManager #2988
Conversation
ProjectileManagager => ProjectileManager
Won’t this break any third party consumers of the |
Yeah, this is both source and binary incompatible, can't rename it. using ProjectileManager = ProjectileManagager; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your very correct, there would have to be a change in all the plugins to support this, as this is hard to do by contacting all the plugin developers I believe that this should go unchanged...
Fair enough, I didn't think about this. Feel free to close this PR. |
@RenderBr if you wish to close this then close the PR with the close button |
For the record, I'm not against this PR, but it'll have to be delayed until the next major update to prevent unnecessary breaking changes in between feature versions |
guess this is a major update thing... |
This is a very simple pull request. I have simply bulk renamed the class that was originally
ProjectileManagager
toProjectileManager
. This is minor, but I felt like it should be done.