You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Currently, the NuGet CI and OTAPI CI use different versions of the .NET SDK. This is not a problem right now but someone might forget to update them in the future. Additionally, introducing a global.json ensures everyone is on the same SDK version and mitigates build problems
Describe the solution you'd like
Introduce a global.json at the repository's top level. This file controls which version of the .NET SDK MSBuild uses, but setup-dotnet(action used to setup .NET in CI) also supports it(in this case the dotnet-version should be removed):
Warning: Unless a concrete version is specified in the global.json file, the latest .NET version installed on the runner (including preinstalled versions) will be used by default. Please refer to the documentation for the currently preinstalled .NET SDK versions.
The example config below specifies 6.0.100 as the SDK version, but allows a leniency of any version under 6.0.*. 6.0.404 passes, but 6.1.100 or 7.0.101 doesn't
It should also be worth to implement the security patches that have been rolled out so far. Considering these patches range from remote code execution (112) to unintended privilege elevation (110), it should be quite important to keep up with them, even if they don't directly apply to the current codebase.
Is your feature request related to a problem? Please describe.
Currently, the NuGet CI and OTAPI CI use different versions of the .NET SDK. This is not a problem right now but someone might forget to update them in the future. Additionally, introducing a global.json ensures everyone is on the same SDK version and mitigates build problems
TShock/.github/workflows/ci-otapi3.yml
Line 16 in 6e589ff
TShock/.github/workflows/ci-otapi3.yml
Line 34 in 6e589ff
TShock/.github/workflows/ci-otapi3-nuget.yml
Line 20 in 6e589ff
Describe the solution you'd like
Introduce a
global.json
at the repository's top level. This file controls which version of the .NET SDK MSBuild uses, but setup-dotnet(action used to setup .NET in CI) also supports it(in this case thedotnet-version
should be removed):The example config below specifies
6.0.100
as the SDK version, but allows a leniency of any version under6.0.*
.6.0.404
passes, but6.1.100
or7.0.101
doesn'tDescribe alternatives you've considered
none considered
Additional context
none
The text was updated successfully, but these errors were encountered: