Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make form for parameter description in public upload #527

Open
mlocardpaulet opened this issue Jan 10, 2025 · 6 comments
Open

make form for parameter description in public upload #527

mlocardpaulet opened this issue Jan 10, 2025 · 6 comments
Assignees

Comments

@mlocardpaulet
Copy link
Contributor

mlocardpaulet commented Jan 10, 2025

Here is how it should work now for public submission:

  1. upload the parameter files
  2. automatic parsing when available
  3. presentation of a pre-filled form that contains all the parameters that are required for public submission. When absent from the parameter file or not parsed, the fields are empty
  4. manual curation from the person providing the data: add missing parameters.
  5. submission

When the PR is sent, it should be reviewed by a ProteoBench curator. To simplify his/her work, we should provide:

  1. the original parsed parameters
  2. the parameter file (the link to them is already available)
  3. the parameters modified by submitter (we could consider flagging differences)
@RobbinBouwmeester
Copy link
Contributor

We should maybe have a look at earlier code where this was actually implemented. Also make sure this is connected to required/visualized parameters in the app.

@enryH
Copy link
Member

enryH commented Jan 16, 2025

So we predefine the parameters as before. So you decided against allowing for free entries? (parameters the researcher deems interesting)?

@mlocardpaulet
Copy link
Contributor Author

So we predefine the parameters as before. So you decided against allowing for free entries? (parameters the researcher deems interesting)?

We decided for something in between. When people submit the parameter file:

  1. a pre-filled form appears containing a set of parsed parameters.
  2. users can fill in the information when it was not parsed (empty fields)
  3. there should be a free-text field for parameters that people would be interested in but are not in "our" list.

Does it answer your question?

@RobbinBouwmeester
Copy link
Contributor

This json is used here:

# TODO: change additional_params_json for other modules, to capture relevant parameters

@RobbinBouwmeester
Copy link
Contributor

Will resolve this and at the same time this issue:

#434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants