-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] support of customized components in monai_bundle_inference_operator #367
Comments
Thanks @mingxin-zheng. As the MONAI Bundle expands its capability, the App SDK MONAI Bundle (automated) Inference operator will need to follow suite in order to support more use cases (as of now, only pre-processing, post-processing, and inferer attributes, besides metadata.json, are supported). I see this enhancement of low to medium difficulty, especially after the load and save image logic is separated out from pre and post processing respectively. |
@MMelQin Thanks for the suggestion and evaluation. I will submit a PR for your review. By looking at the code, I am confused by the way to get MONAI bundle config and files.
But the MONAI bundles are in a different format (example). Is there an example how MONAI deploy can deploy the current MONAI bundle in the model zoo? |
@mingxin-zheng MONAI Bundle IS a TorchScript with extra config data in JSON. The example application using MONAI Bundle is the Spleen Seg, and the model is from Model Zoo Spleen Bundle. I have notice the bundle itself has changed over time, but the format remains the same. |
@MMelQin Thanks for the confirmation. I started with the assumption that bundle isn't always TorchScript. By looking at the storage, it seems most has .ts in the Maybe we make deploy to adapt both (torchscript and non-torchscript)? @MMelQin @Nic-Ma |
That would be too arbitrary and was the exact reason why we picked the common and standard model archive format. |
Okay I see. I downloaded all the bundles and check which model actually HAS
I may close this ticket as the issue sounds different that how it was first framed... |
Expand support for more Bundles with additional attributes or components. Some of them are custom and already supported for Core and Label. Today we only support pre-transform, inference and post-transform. |
Is your feature request related to a problem? Please describe.
Currently MONAI bundle allows user to define their components (class) and supports the initiation of the class from the bundle template during inference. We can possibly extend monai_bundle_inference_operator.py to better support these customized components
The text was updated successfully, but these errors were encountered: