Skip to content

Commit 8946b97

Browse files
committed
Merge pull request #92 from ProgrammingLife3/feature/square
Change shape of unwrappable node to a square.
2 parents 80fff76 + 1753908 commit 8946b97

File tree

11 files changed

+54
-22
lines changed

11 files changed

+54
-22
lines changed

resources/stylesheet.css

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -24,19 +24,10 @@ node:selected {
2424
size: 25;
2525
}
2626

27-
node.HorizontalWrapper {
27+
node.BOX {
2828
shape: box;
2929
}
3030

31-
node.SpaceWrapper {
32-
shape: diamond;
33-
size: 20;
34-
}
35-
36-
node.VerticalWrapper {
37-
shape: cross;
38-
}
39-
4031
node.FixWrapper {
4132
visibility-mode: hidden;
4233
}

src/main/java/tudelft/ti2806/pl3/data/wrapper/CombineWrapper.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,8 @@ public void calculateX() {
8282
}
8383
this.x /= this.getNodeList().size();
8484
}
85-
85+
86+
@Override
8687
public boolean canUnwrap() {
8788
return true;
8889
}

src/main/java/tudelft/ti2806/pl3/data/wrapper/DataNodeWrapper.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,11 @@ public String getIdString() {
7676
return node.getId();
7777
}
7878

79+
@Override
80+
public boolean canUnwrap() {
81+
return false;
82+
}
83+
7984
@Override
8085
public Set<Genome> getGenome() {
8186
return node.getCurrentGenomeSet();

src/main/java/tudelft/ti2806/pl3/data/wrapper/FixWrapper.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,11 @@ public int getId() {
3131
return id;
3232
}
3333

34+
@Override
35+
public boolean canUnwrap() {
36+
return false;
37+
}
38+
3439
@Override
3540
public Set<Genome> getGenome() {
3641
return genome;

src/main/java/tudelft/ti2806/pl3/data/wrapper/SingleWrapper.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,12 @@ public String getIdString() {
4545
public int getId() {
4646
return this.target.getId();
4747
}
48-
48+
49+
@Override
50+
public boolean canUnwrap() {
51+
return false;
52+
}
53+
4954
@Override
5055
public Set<Genome> getGenome() {
5156
return this.target.getGenome();

src/main/java/tudelft/ti2806/pl3/data/wrapper/Wrapper.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,9 @@ public void setOutgoingWeight(List<Integer> outgoingWeight) {
8888
public abstract String getIdString();
8989

9090
public abstract int getId();
91-
91+
92+
public abstract boolean canUnwrap();
93+
9294
public abstract Set<Genome> getGenome();
9395

9496
public abstract void calculate(WrapperOperation wrapperSequencer, Wrapper container);

src/main/java/tudelft/ti2806/pl3/data/wrapper/WrapperClone.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,11 @@ public String getIdString() {
5050
return originalNode.getId();
5151
}
5252

53+
@Override
54+
public boolean canUnwrap() {
55+
return originalNode.canUnwrap();
56+
}
57+
5358
@Override
5459
public Set<Genome> getGenome() {
5560
return originalNode.getGenome();

src/main/java/tudelft/ti2806/pl3/data/wrapper/WrapperPlaceholder.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,11 @@ public int getId() {
2929
return ID;
3030
}
3131

32+
@Override
33+
public boolean canUnwrap() {
34+
return true;
35+
}
36+
3237
@Override
3338
public Set<Genome> getGenome() {
3439
return null;

src/main/java/tudelft/ti2806/pl3/visualization/GraphView.java

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -130,15 +130,18 @@ public void generateGraph() {
130130
/ (panel.getBounds().width * zoomLevel / zoomedGraphModel.getWrappedCollapsedNode().getWidth())
131131
/ zoomedGraphModel.getWrappedCollapsedNode().getGenome().size();
132132
graphData.forEach(node -> {
133-
Node graphNode = graph.addNode(Integer.toString(node.getId()));
134-
double y = node.getY() * someSize;
135-
graphNode.setAttribute("xy", node.getX(), y);
136-
graphNode.addAttribute("ui.class", node.getOriginalNode().getClass().getSimpleName());
137-
graphNode.addAttribute("ui.label",
138-
NumberFormat.getNumberInstance(Locale.US)
139-
.format(node.getOriginalNode().getBasePairCount()));
140-
graphNode.setAttribute("node", node);
141-
});
133+
Node graphNode = graph.addNode(Integer.toString(node.getId()));
134+
double y = node.getY() * someSize;
135+
graphNode.setAttribute("xy", node.getX(), y);
136+
if (node.canUnwrap()) {
137+
graphNode.addAttribute("ui.class", "BOX");
138+
}
139+
graphNode.addAttribute("ui.label",
140+
NumberFormat.getNumberInstance(Locale.US)
141+
.format(node.getOriginalNode().getBasePairCount()));
142+
graphNode.setAttribute("node", node);
143+
}
144+
);
142145

143146
for (WrapperClone node : graphData) {
144147
int i = 0;

src/test/java/tudelft/ti2806/pl3/data/wrapper/TestWrapper.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,11 @@ public String getIdString() {
5656
return id;
5757
}
5858

59+
@Override
60+
public boolean canUnwrap() {
61+
return false;
62+
}
63+
5964
@Override
6065
public Set<Genome> getGenome() {
6166
return genomeSet;

src/test/java/tudelft/ti2806/pl3/util/OrderedListUtilTest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,11 @@ public int getId() {
119119
return 0;
120120
}
121121

122+
@Override
123+
public boolean canUnwrap() {
124+
return false;
125+
}
126+
122127
@Override
123128
public Set<Genome> getGenome() {
124129
return new HashSet<>();

0 commit comments

Comments
 (0)