-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reviews #1
Comments
|
For instance, it's clear from the manipulation of oscillation strength in the model of Schlichting et al that this parameter can dramatically change the direction of the results. The authors do report the oscillation strength parameter values that they used in the other two models, but it is not clear how sensitive these models are to small changes in this value. ACTION ITEM I’m not sure that R1 is interested in this. But if it’s easy enough, we could try manipulating osc amount in the Chanales and Favila sims to see what happens (e.g., it’s possible that slightly increasing osc size in favila will lead to a situation where you get some differentiation in the different face condition but more in the same face condition, which aligns better with the actual data – see reviewer comment towards the end of this doc) Similarly, it's not clear whether the 2/6 hidden layer overlap (only explicitly manipulated in the model of Chanales et al) is required for the other two models to work. ACTION ITEM: I agree with this plan [also, note that, in practice, i think we may be able to “shift” differentiation to the 3/6 condition by using a different oscillation size – we should try to do this] |
python figs.py alex_sep_5_oscamnt --data_dir=/scratch/qanguyen/chanales --searchvar=Hidden_ColorRecall_Layer_OscAmnt |
python figs.py alex_aug_24_interleave --data_dir=/scratch/qanguyen/schlichting --searchvar=LRateOverAllpython figs.py alex_aug_24_blocked --data_dir=/scratch/qanguyen/schlichting --searchvar=LRateOverAlland same day with favilaTO DO: rerun job with more parameters, just use boundary_condition_plots ipynb scriptThe text was updated successfully, but these errors were encountered: