Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partial dates are always sorted last in the book circulation card display, even if year or year/month are known #662

Open
clmahoney opened this issue Jun 7, 2020 · 2 comments
Labels

Comments

@clmahoney
Copy link

clmahoney commented Jun 7, 2020

Describe the bug
If a periodical has a month and a year but no specific date, it's coming in last in the card display, even if the year is earlier than other cards with specific dates. Similarly, if the event is GENERIC and not a borrow or a purchase, it's coming in last too.

To reproduce
See this one borrow from April 1937 on Culver's card:
Screen Shot 2020-06-07 at 7 11 52 PM

See this generic event for Perkins:
Screen Shot 2020-06-07 at 8 52 22 PM

Expected behavior
We want the cards to be listed in order of date even if the borrow/purchase event is only month and year.

@clmahoney clmahoney added the bug label Jun 7, 2020
@clmahoney clmahoney changed the title I want periodicals without individual borrow dates to be sorted by year in the book circulation card display I want periodicals without individual borrow dates or GENERIC events to be sorted by year in the book circulation card display Jun 8, 2020
@rlskoeser
Copy link
Contributor

@clmahoney please include links to example problem pages on the public site to make it easier to find and reproduce the problem. I can see what's happening in your screenshots but it's not obvious which titles you're looking at.

@rlskoeser rlskoeser changed the title I want periodicals without individual borrow dates or GENERIC events to be sorted by year in the book circulation card display partial dates are always sorted last in the book circulation card display, even if year or year/month are known Jun 11, 2020
@clmahoney
Copy link
Author

My apologies! Of course:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants