Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css-loader 7 and sass-loader 14 is not compatible with Node16 #36119

Open
2 tasks done
leemyongpakva opened this issue May 9, 2024 · 1 comment
Open
2 tasks done

css-loader 7 and sass-loader 14 is not compatible with Node16 #36119

leemyongpakva opened this issue May 9, 2024 · 1 comment
Labels
8.1.x Branch Blockreassurance Module: blockreassurance Bug Type: Bug CO Category: Core Faceted search Module: ps_facetedsearch Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Module Module Ready Status: Issue is ready to be worked on Verified The issue has been reproduced

Comments

@leemyongpakva
Copy link

Prerequisites

Describe the bug and add attachments

css-loader 7 and sass-loader 14 in current devDependencies of blockreassurance and ps_facetedsearch require at least Node18 so npm install for these two modules throw warning as screenshots below.
css7_sass14_loader_node16_blockreassurance
css7_sass14_loader_node16_facetedsearch

Expected behavior

npm install for these two modules complete without Unsupported engine warning.

Steps to reproduce

  1. git clone module repo
  2. cd to module folder and switch to node16
  3. run npm install and see warnings

PrestaShop version(s) where the bug happened

8.0

PHP version(s) where the bug happened

7.3

If your bug is related to a module, specify its name and its version

blockreassurance v6.0.0, ps_facetedsearch v3.15.2

Your company or customer's name goes here (if applicable).

No response

@leemyongpakva leemyongpakva added Bug Type: Bug New New issue not yet processed by QA labels May 9, 2024
@florine2623
Copy link
Contributor

Hello @leemyongpakva ,

I have reproduced your issue with blockreassurance and ps_facetedsearch :

Screenshot 2024-05-14 at 11 47 17

Please be aware that some issues might take a very long time to be resolved. If this one is important to you and you cannot wait for it to be fixed on the project’s own time, we strongly suggest you consider contacting a professional to help you.

If you fix the issue on your end, please contribute it back to the project. Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thank you

@florine2623 florine2623 added Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification CO Category: Core Verified The issue has been reproduced Module Module Ready Status: Issue is ready to be worked on Faceted search Module: ps_facetedsearch Blockreassurance Module: blockreassurance 8.1.x Branch and removed New New issue not yet processed by QA labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.1.x Branch Blockreassurance Module: blockreassurance Bug Type: Bug CO Category: Core Faceted search Module: ps_facetedsearch Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Module Module Ready Status: Issue is ready to be worked on Verified The issue has been reproduced
Projects
None yet
Development

No branches or pull requests

2 participants