[Idea] Change specific price date ranges to DateTime #32244
Replies: 25 comments 1 reply
-
Hi @bmwjoeytsang, Thanks for your report. |
Beta Was this translation helpful? Give feedback.
-
Yes, I think it will be nice to add it @colinegin wdyt ? |
Beta Was this translation helpful? Give feedback.
-
This is a major regression (you should add that tag), there are legal constraints in France for sales period (next winter sales should start at 8 in the morning for example) |
Beta Was this translation helpful? Give feedback.
-
Thank you for your feedback @benoth , I agree with you it is an important feature that we should add back to specific prices. I need to discuss with the team see if we can add it to our 1.7.6 roadmap, we will keep you updated. |
Beta Was this translation helpful? Give feedback.
-
See PR : #8571 |
Beta Was this translation helpful? Give feedback.
-
Hi, New suggestion by @PrestaShark, Change from Thanks! |
Beta Was this translation helpful? Give feedback.
-
/src/PrestaShopBundle/Form/Admin/Product/ProductSpecificPrice.php to
from
|
Beta Was this translation helpful? Give feedback.
-
Works fine but with style slitches. For me its not a problem. Now i can wait calm for official implementation in 1.7.7 |
Beta Was this translation helpful? Give feedback.
-
@marionf do you think we will be able to add this option with the rework on the product page? |
Beta Was this translation helpful? Give feedback.
-
@colinegin yes, we talked about that with @matks |
Beta Was this translation helpful? Give feedback.
-
Hi , did you have some news ? we are stuck with this issue on 1.7.6.5, impossible to add the hours |
Beta Was this translation helpful? Give feedback.
-
Hi, Here is a dirty, but working solution for 1.7.6.5: In src/prestashopBundle/Resources/view/admin/productPage/Forms/form_specific_price.html.twig Do the same for {{ form_widget(form.sp_to) }}: dump it, copy the html input, remove datepicker class and set type="datetime-local". See next post ==> |
Beta Was this translation helpful? Give feedback.
-
Now we have to format correctly the date for database, since html datetime-local don't format like datepicker. Change function processProductSpecificPrice:
Go next and last post ==> |
Beta Was this translation helpful? Give feedback.
-
Now we have to reformat it for form displaying (when updating) function updateAction:
Function formatSpecificPriceToPrefillForm
Now, Add this function:
|
Beta Was this translation helpful? Give feedback.
-
Hello, it is planned to be added to at least the product page for the 178 version. ping @MatShir FYI |
Beta Was this translation helpful? Give feedback.
-
@colinegin Are you sure ? Because this is a big change. Allowing people to select minutes inside the BO page is only a small part of the overall needed work. Because then we must also update all the code logic that relies on it. There is guarantee that the checkout logic that will be used to compute the cart total will work with minutes immediately, as today it only acknowledges hours. Modifying the calendar is only a piece of the puzzle, and not solving the complete puzzle would be useless IMO. If you create a specific price that activate at 17pm27 but the code behind it only activates at 18pm00 it's useless. |
Beta Was this translation helpful? Give feedback.
-
To be discussed with @MatShir then, because this issue is part of the Pricing tab EPIC : #19673 This is quite an old topic, it's one of the big regressions of 17 vs 16, this feature has been removed from migrated pages, while it's available on legacy pages. So if I remember correctly (i might be wrong), the code is still able to manage minutes but the back office no longer allows it. |
Beta Was this translation helpful? Give feedback.
-
Hello @matks, This is a big change but we also need this component for other pages such as Cart Rules. Merchants need to inform the date/hour/min of their discounts. |
Beta Was this translation helpful? Give feedback.
-
The design is something we can handle quite easily 😄 but it cannot be delivered alone. If we want to allow merchants to select minutes:
*If we dont do this step, the following scenario could happen:
So I want to highlight that, because of "any prestashop logic that uses these informations must be updated" part, this is actually a big change 😄 |
Beta Was this translation helpful? Give feedback.
-
Unfortunately this problem never seem to have been fixed. In Discount/Voucher section it is possible to set actual time - but never seem to have been fixed for Specific Prices in PS1.7. Is there a quickfix for this, as it is very annoying during one-day offers like Black Friday, not being able to adjust this?! |
Beta Was this translation helpful? Give feedback.
-
No fix currently for this issue, but you can a cart rule with product constraints and a time constraint. But I know it is not ideal. 😞 |
Beta Was this translation helpful? Give feedback.
-
Hello! As they still haven't decided to put the time to work in the date-picker of discounts. Wouldn't it be possible to take 1 day off the code that shows the end date of the promotion? This code displays the end date of the promotion, but due to the time issue the promotion ends before the end of the day, so we have to add a day on the backoffice side. And the idea in this code was to remove the extra day to hit the date right, you know? {l s='End promo: '}{$product->specificPrice.to|date_format:'%d-%m-%Y' . "-1 days""} I await your comments. Thanks! |
Beta Was this translation helpful? Give feedback.
-
1.7.8.8 and the problem is not fixed yet. |
Beta Was this translation helpful? Give feedback.
-
Fixed from the 8.1.3 release :) Here the PR for the curious tech savy |
Beta Was this translation helpful? Give feedback.
-
Describe the bug
We had multiple shop which was running PS1.6 and PS1.7.4.4. I found that in PS1.6, we can click the from date / time and to date / time in product -> Add a specific price. However, In PS1.7, I found we only can select the from date and to date only, but we have some promotion want start at specific time (e.g: 20% discount start at 15:00 and end at 18:00.
Is it PS1.7 not allow to set specific price with time range?
To Reproduce
Steps to reproduce the behavior:
Screenshots
(https://user-images.githubusercontent.com/38032785/48235897-e0581c00-e3fa-11e8-8360-327653eb30bd.png)
Additionnal information
PrestaShop version: 1.7.3.2 and 1.7.4.4
PHP version: 7.0.31
Beta Was this translation helpful? Give feedback.
All reactions