Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support for multiple generic FeatureModalities for items #592

Open
angelogeninatti opened this issue Jan 25, 2024 · 1 comment

Comments

@angelogeninatti
Copy link

Description

In my use case, I need to incorporate multiple modalities inside my data, including Audio and Video. As of right now, the only way I found to incorporate them both is to concatenate them in a single FeatureModality object, which is not ideal. It would be best to be able to use a list of FeatureModality objects.

Expected behavior with the suggested feature

As of right now, the only way to do it is:
item_embeddings = FeatureModality(features=[Concatenated Modalities], ids=...)
ratio_split = RatioSplit(
data=dataset,
test_size=0.1,
item_feature=item_embeddings
)

It would be best to have something like:
item_embeddings = [FeatureModality(features=Modality 1, ids=...), FeatureModality(features=Modality 2, ids=...)]
ratio_split = RatioSplit(
data=dataset,
test_size=0.1,
item_feature_list=item_embeddings
)

Other Comments

None

@angelogeninatti angelogeninatti changed the title [FEATURE] Support for multiple generic FeatureModalities [FEATURE] Support for multiple generic FeatureModalities for items Jan 25, 2024
@tqtg
Copy link
Member

tqtg commented Jan 26, 2024

This is very interesting use case. What we should do is to add more modalities (e.g., Audio) into our framework similarly to others, instead of concatenate different modalities into one. By default, any modality should extend from and behave like a FeatureModality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants