Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Code rewrite #50

Open
lonelytransistor opened this issue Jan 4, 2023 · 7 comments
Open

[FEATURE REQUEST] Code rewrite #50

lonelytransistor opened this issue Jan 4, 2023 · 7 comments

Comments

@lonelytransistor
Copy link

Haiii!

So if you look at my repo, you can see that I have changed "a bit". I've rewritten most of your code to suit my needs, mostly my need for a touchscreen. I've added a KDEConnect card, I've rewritten the Components and I've added a drag-n-drop way of setting what is available on the panel's screen. Now each card has a "small" representation, which is visible as soon as the plasmoid is expanded, and a "big" representation, which is shown if you flick the top side of the card upwards or click it with your mouse.

Please let me know if this is interesting to you. I'm tempted to make a clone out of this, but since it was your idea originally, I won't do it unless you tell me to, because e.g. it collides with your own ideas for the plasmoid.

@Prayag2
Copy link
Owner

Prayag2 commented Jan 4, 2023

I've added a drag-n-drop way of setting what is available on the panel's screen

That sounds amazing!
Can you please share a video of it?

@lonelytransistor
Copy link
Author

lonelytransistor commented Jan 4, 2023

Nope, but I can attach screenshots of what I mean.
What the plasmoid looks like on my end:
1
What it looks like to expand one of the cards:
2
What the config now looks like:
3
Bonus, the battery now has a graph:
4

@Prayag2
Copy link
Owner

Prayag2 commented Jan 4, 2023

I'm tempted to make a clone out of this, but since it was your idea originally, I won't do it unless you tell me to

I just saw your code. It seems like you did a LOT of work! I have no problem with you making a clone of it!

@lonelytransistor
Copy link
Author

The way I see it, it's better to have two programmers than one, that's why I suggest combining our work. I haven't ported all of your original components yet and the code needs cleaning. If you decide that you would prefer to maintain your plasmoid yourself, then I will make a clone of it and upload it to the KDE store, but if you think it would be beneficial to maintain the code together, I'm happy to cocreate this plasmoid. What would be your preference?

@Prayag2
Copy link
Owner

Prayag2 commented Jan 4, 2023

I have exams in 20 days so I'll think about it after that :)

@lonelytransistor
Copy link
Author

Ok! Good luck on your exams!

@ryu-ketsueki
Copy link

It would seem this widget will need yet another rewrite if it is going to work on Plasma 6. I don't understand QML. I tried doing widgets in the past but I can't wrap my head around it so I can't port it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants