Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIM E2E Test Broken by VIM Ubuntu Package 8.2.3995-1ubuntu2.19 #2182

Open
JustinGrote opened this issue Oct 2, 2024 · 5 comments
Open

VIM E2E Test Broken by VIM Ubuntu Package 8.2.3995-1ubuntu2.19 #2182

JustinGrote opened this issue Oct 2, 2024 · 5 comments
Assignees

Comments

@JustinGrote
Copy link
Collaborator

https://github.com/PowerShell/PowerShellEditorServices/actions/runs/11132769096/job/30937371296?pr=2152

@JustinGrote
Copy link
Collaborator Author

JustinGrote commented Oct 2, 2024

Test works fine in upterm, weird. What context is different in the run env I wonder?
image

@JustinGrote
Copy link
Collaborator Author

@andyleejordan I think whatever VIM you're downloading, something in the latest version broke the tests. If I remove the ENV to the executable, the test completes, see this PR:
#2183

@JustinGrote
Copy link
Collaborator Author

JustinGrote commented Oct 2, 2024

Looks like package updated to vim-gtk3 8.2.3995-1ubuntu2.19, it was ubuntu2.18 before, something in that update appears to have broken it.
https://launchpad.net/ubuntu/+source/vim/2:8.2.3995-1ubuntu2.19

@JustinGrote JustinGrote changed the title VIM E2E Test Broken Assignees: @andyleejordan @JustinGrote Labels: bug Milestone: Projects: VIM E2E Test Broken by VIM Ubuntu Package 8.2.3995-1ubuntu2.19 Oct 2, 2024
@JustinGrote
Copy link
Collaborator Author

JustinGrote commented Oct 2, 2024

@andyleejordan nightly works fine, so I adjusted the github action to use nightly, see this PR:
#2183

We will need to actually verify if the extension is actually broken due to this security update package, since it is the current stable ubuntu package and will have widespread usage, and determine if it's something with us or with vim or their lsp client (it's not clear from the test)

@andyleejordan
Copy link
Member

Yay for fun new bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants