Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify if the nullable columns that have a default value are "required" #5

Open
laurenceisla opened this issue Jun 7, 2023 · 2 comments
Open

Verify if the nullable columns that have a default value are "required" #5

laurenceisla opened this issue Jun 7, 2023 · 2 comments

Comments

@laurenceisla
Copy link
Member

laurenceisla commented Jun 7, 2023 •
edited

Are not nullable columns that have a default value required? For instance, if a column is_completed has a default of false, then even if it's not included in the body, then the request still completes, thus not required. There's a special case for generated ids too, they shouldn't be included in the body.

Originally posted by @laurenceisla in https://github.com/laurenceisla/postgrest-openapi/pull/3#discussion_r1198485530
@laurenceisla
Copy link
Member Author

This may be related: https://swagger.io/docs/specification/describing-parameters/#mistakes

@laurenceisla
Copy link
Member Author

This seems to confirm it: PostgREST/postgrest#1653 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laurenceisla