test fixes

Author: liyiy

capture_test.go

@@ -52,15 +52,3 @@ func TestCaptureValidWithDistinctId(t *testing.T) {
 		t.Error("validating a valid capture object failed:", capture, err)
 	}
 }
-
-func TestGroupsCapture(t *testing.T) {
-	// capture := Capture{
-	// 	Event: "1",
-	// 	DistinctId: "2",
-	// 	Groups: Groups{}.Set("company", "id:5").Set("instance", "app.posthog.com"),
-	// }
-
-	// if e, ok := capture.Validate()(FieldError); !ok {
-	// 	t.Error("???", err)
-	// }
-}

group_identify.go

@@ -19,11 +19,19 @@ func (msg GroupIdentify) internal() {
 }
 
 func (msg GroupIdentify) Validate() error {
-	if len(msg.DistinctId) == 0 {
+	if len(msg.Type) == 0 {
 		return FieldError{
 			Type:  "posthog.GroupIdentify",
-			Name:  "DistinctId",
-			Value: msg.DistinctId,
+			Name:  "Type",
+			Value: msg.Type,
+		}
+	}
+
+	if len(msg.Key) == 0 {
+		return FieldError{
+			Type:  "posthog.GroupIdentify",
+			Name:  "Key",
+			Value: msg.Key,
 		}
 	}
 

group_identify_test.go

@@ -2,7 +2,7 @@ package posthog
 
 import "testing"
 
-func TestGroupIdentifyMissingDistinctId(t *testing.T) {
+func TestGroupIdentifyMissingType(t *testing.T) {
 	groupIdentify := GroupIdentify{}
 
 	if err := groupIdentify.Validate(); err == nil {
@@ -13,16 +13,34 @@ func TestGroupIdentifyMissingDistinctId(t *testing.T) {
 
 	} else if e != (FieldError{
 		Type:  "posthog.GroupIdentify",
-		Name:  "DistinctId",
+		Name:  "Type",
+		Value: "",
+	}) {
+		t.Error("invalid error value returned when validating group identify:", err)
+	}
+}
+func TestGroupIdentifyMissingKey(t *testing.T) {
+	groupIdentify := GroupIdentify{}
+
+	if err := groupIdentify.Validate(); err == nil {
+		t.Error("validating an invalid group identify object succeeded:", groupIdentify)
+
+	} else if e, ok := err.(FieldError); !ok {
+		t.Error("invalid error type returned when validating group identify:", err)
+
+	} else if e != (FieldError{
+		Type:  "posthog.GroupIdentify",
+		Name:  "Key",
 		Value: "",
 	}) {
 		t.Error("invalid error value returned when validating group identify:", err)
 	}
 }
 
-func TestGroupIdentifyValidWithDistinctId(t *testing.T) {
-	groupIdentify := Identify{
-		DistinctId: "organization_id:5",
+func TestGroupIdentifyValidWithTypeAndKey(t *testing.T) {
+	groupIdentify := GroupIdentify{
+		Type: "organization",
+		Key:  "id:5",
 	}
 
 	if err := groupIdentify.Validate(); err != nil {