Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark_as_modified doesn't work correctly with scale parameters #232

Open
anth-volk opened this issue Aug 1, 2024 · 0 comments
Open

mark_as_modified doesn't work correctly with scale parameters #232

anth-volk opened this issue Aug 1, 2024 · 0 comments

Comments

@anth-volk
Copy link
Contributor

For example, say I want to take an Alabama state income tax bracket and run the mark_as_modified() method upon it. It appears that gov.states.al.tax.income.rates[1] doesn't recognize gov.states.al.tax.income.rates as its parent, thereby preventing mark_as_modified() from recursing further up the tree.

The downstream impact of this is that, if I wanted to use cached values while calculating (assuming all other current issues we have with state-level caching were gone), the simulation wouldn't correctly recurse all the way to gov.states, thereby giving an erroneous output for household_state_income_tax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant