Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create raft of tests for structural reforms #1885

Open
anth-volk opened this issue Oct 16, 2024 · 0 comments
Open

Create raft of tests for structural reforms #1885

anth-volk opened this issue Oct 16, 2024 · 0 comments

Comments

@anth-volk
Copy link
Collaborator

There would be a lot of value to adding a series of tests around creating structural reforms with the following:

  • A reform using a neutralize_variable value on an existing piece of the default tax-benefit system
  • A reform using an update_variable value on an existing piece of the default tax-benefit system
  • A reform using an update_variable value to create a totally new variable in the system

All of these should be run in the following four-step manner:

  • For a relevant test household, baseline, no axes
  • Test household, reform, no axes
  • Test household, baseline, axes
  • Test household, reform, axes

This mimics the series of calls that occurs if a user inputs a reform, inputs a household, views their net income output, then clicks "Varying your earnings".

Each output should confirm that:

  • household_net_income is a valid value
  • Each of the default outputs is a valid value (we could even drill down the tree using metadata to ensure every possible display value is valid, depending on how long that makes the test time-wise)
  • Some variable added or altered by the structural reform is present and valid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant