Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If microsimulation worker crashes, raise some sort of error to allow API (and subsequently, app) to show error message #1815

Open
anth-volk opened this issue Sep 23, 2024 · 4 comments

Comments

@anth-volk
Copy link
Collaborator

The API never actually fails if the worker does when calculating microsimulation outputs. It'd be great to have some sort of error raising behavior that allows the app to show an error message.

@nikhilwoodruff
Copy link
Collaborator

I think this is fixed now? e.g. you can see error stack traces for the UK simulations that fail.

@anth-volk
Copy link
Collaborator Author

anth-volk commented Sep 26, 2024

True, but what happens is that the API itself will continue to emit GET requests to the endpoint endlessly, causing a spinner, unless I'm mistaken. Though the sim itself will fail, that fact will never be registered by the get_calculate endpoint.

@anth-volk anth-volk reopened this Sep 26, 2024
@nikhilwoodruff
Copy link
Collaborator

Do you mean the economy endpoint? Or are we talking about household impacts

@anth-volk
Copy link
Collaborator Author

economy endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants