-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify/Refactor Archives Logic #309
Comments
@maxachis I think this is coming from/used by code in the automatic-archives repo: https://github.com/Police-Data-Accessibility-Project/automatic-archives |
@josh-chamberlain Related to what is discussed in this issue, I think setting up an Also (and possibly relevant to the above point), I would like to know by what conditions we determine whether a data source should be archived, or if every data source should be archived. |
If I'm following the archive logic correctly in the SQL query, in plain english: So we basically don't want to waste time archiving sources that are never updated and have already been archived or are broken |
@EvilDrPurple nailed it! want to work on this issue / the other one linked? this is not related to v2, but it's still pretty important that it works correctly and clearly. One day we will get more sophisticated than internet archive. @maxachis agreed. it was built by someone without a ton of experience, so it makes sense that there would be room for improvement and clarity! at most, I'd consider renaming this issue to something like "separate archives logic from data sources app". Ideally, our API would just |
@josh-chamberlain yeah sure! I believe I may need access to the database but I can start on it |
The Archives resource and its attendant functionality is unclear to me on several levels:
I'd like to figure out the answer to these questions, and possibly refactor the Archives resource for improved clarity, or update the documentation.
related to Police-Data-Accessibility-Project/automatic-archives#21
The text was updated successfully, but these errors were encountered: