-
Notifications
You must be signed in to change notification settings - Fork 6
Closed
Police-Data-Accessibility-Project/data-sources-app-v2-archive
#50Labels
enhancement 👑New feature or requestNew feature or requestpython 🐍Pull requests that update Python codePull requests that update Python code
Description
There are several cases where an environmental variable is pulled but where no clear error is thrown when the environmental variable is not provided.
For example, login_queries.py
:
def create_session_token(cursor: PgCursor, user_id: int, email: str) -> str:
"""
Generates a session token for a user and inserts it into the session_tokens table.
....
"""
# ...
session_token = jwt.encode(payload, os.getenv("SECRET_KEY"), algorithm="HS256")
# ...
This can cause confusion, especially for developers, who will have to dig into the code to find out that the cause of an error is a missing environmental variable.
Tests should additionally be added to ensure the app functions appropriately when environmental variables are not provided.
Metadata
Metadata
Assignees
Labels
enhancement 👑New feature or requestNew feature or requestpython 🐍Pull requests that update Python codePull requests that update Python code