Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc cleanup for automatic-archives #18

Open
2 of 4 tasks
josh-chamberlain opened this issue Jun 3, 2024 · 5 comments
Open
2 of 4 tasks

misc cleanup for automatic-archives #18

josh-chamberlain opened this issue Jun 3, 2024 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@josh-chamberlain
Copy link
Contributor

josh-chamberlain commented Jun 3, 2024

Context

The main contributor for this project couldn't continue, so we left a few things unpolished.

Requirements

  • we're using the PDAP API, SPN API, and last_cached and url_status properties in the database to track this, but we need to update the readme to reflect all that
  • the github action isn't working at the moment
  • I think we should change the word "cache" to "archive" throughout

Docs

  • changing the name of a property in the db affects data dictionary and the README
@josh-chamberlain josh-chamberlain added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 3, 2024
@josh-chamberlain
Copy link
Contributor Author

josh-chamberlain commented Jun 3, 2024

fixed first task in #17

@maxachis maxachis self-assigned this Jun 3, 2024
@maxachis
Copy link
Contributor

maxachis commented Jun 3, 2024

@josh-chamberlain On it! I will need two environment keys. They're not described in the README, so I'm lacking some context.

VITE_VUE_APP_BASE_URL
VUE_APP_PDAP_API_KEY

@maxachis
Copy link
Contributor

maxachis commented Jun 4, 2024

  • I think we should change the word "cache" to "archive" throughout

Note to myself (mostly): This will require changes to the database and presumably endpoints touching it as well, which will require some PRs outside of this project.

@josh-chamberlain
Copy link
Contributor Author

@maxachis those are both org-level secrets, they're used by data-sources-app as well

@maxachis
Copy link
Contributor

maxachis commented Jun 6, 2024

@josh-chamberlain Got it. I could probably benefit from receiving them privately, just so I can test the functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants