Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Update Pipedrive components to latest SDK / API version #15625

Closed
andrewjschuang opened this issue Feb 14, 2025 · 2 comments · Fixed by #15651
Closed

[BUG] Update Pipedrive components to latest SDK / API version #15625

andrewjschuang opened this issue Feb 14, 2025 · 2 comments · Fixed by #15651
Assignees
@luancazarine
Labels
bug Something isn't working

Comments

@andrewjschuang
Copy link
Collaborator

andrewjschuang commented Feb 14, 2025 •
edited
Loading

Describe the bug
Current Pipedrive components are using an old SDK version (see here). We should either update the code to use the latest SDK version or use the v2 API using @pipedream/platform axios

Node.js SDK
API v2
API v2 migration guide
@andrewjschuang andrewjschuang added the bug Something isn't working label Feb 14, 2025
@luancazarine luancazarine self-assigned this Feb 14, 2025
@luancazarine luancazarine moved this from Prioritized to Doing in Component (Source and Action) Backlog Feb 14, 2025
@Ahmad-anility Ahmad-anility mentioned this issue Feb 15, 2025
Closed
luancazarine added a commit that referenced this issue Feb 18, 2025
@luancazarine
[BUG] Update Pipedrive components to latest SDK / API version #15625
94132f2 
All sources and actions refactored
@luancazarine luancazarine mentioned this issue Feb 18, 2025
Merged
@luancazarine luancazarine linked a pull request Feb 18, 2025 that will close this issue
15625 bug update pipedrive components to latest sdk api version #15651
Merged
@luancazarine luancazarine moved this from Doing to Ready for PR Review in Component (Source and Action) Backlog Feb 18, 2025
@michelle0927 michelle0927 moved this from Ready for PR Review to Changes Required in Component (Source and Action) Backlog Feb 18, 2025
@luancazarine luancazarine moved this from Changes Required to Ready for PR Review in Component (Source and Action) Backlog Feb 18, 2025
@michelle0927 michelle0927 moved this from Ready for PR Review to Ready for QA in Component (Source and Action) Backlog Feb 18, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Feb 19, 2025
@vunguyenhung vunguyenhung moved this from In QA to Changes Required in Component (Source and Action) Backlog Feb 19, 2025
@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/BUG-Update-Pipedrive-components-to-latest-SDK-API-version-19ebf548bb5e816e8136ddddffb047d9

@luancazarine luancazarine moved this from Changes Required to Ready for QA in Component (Source and Action) Backlog Feb 19, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to Ready for Release in Component (Source and Action) Backlog Feb 20, 2025
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/BUG-Update-Pipedrive-components-to-latest-SDK-API-version-19ebf548bb5e816e8136ddddffb047d9

luancazarine added a commit that referenced this issue Feb 20, 2025
@luancazarine
15625 bug update pipedrive components to latest sdk api version (#15651)
e0910d2 
* [BUG] Update Pipedrive components to latest SDK / API version #15625
All sources and actions refactored

* pnpm update

* update package.json version

* pnpm update

* pnpm update

* some adjusts

* remove yarn.lock

* some adjusts

* pnpm update
@github-project-automation github-project-automation bot moved this from Ready for Release to Done in Component (Source and Action) Backlog Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luancazarine luancazarine

Labels
bug Something isn't working
Projects
Component (Source and Action) Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

15625 bug update pipedrive components to latest sdk api version PipedreamHQ/pipedream
3 participants
@luancazarine @andrewjschuang @vunguyenhung