Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into updating Google Ads API version #15559

Open
dannyroosevelt opened this issue Feb 11, 2025 · 2 comments · May be fixed by #15591
Open

Look into updating Google Ads API version #15559

dannyroosevelt opened this issue Feb 11, 2025 · 2 comments · May be fixed by #15591
Assignees
@michelle0927
Labels
enhancement New feature or request triaged For maintainers: This issue has been triaged by a Pipedream employee

Comments

@dannyroosevelt
Copy link
Collaborator

dannyroosevelt commented Feb 11, 2025 •
edited
Loading

Looks like we're currently on 16, the latest I think is 18.
https://developers.google.com/google-ads/api/docs/release-notes
https://github.com/PipedreamHQ/pipedream/blob/master/components/google_ads/google_ads.app.mjs

Can we safely update?
@dannyroosevelt dannyroosevelt added the enhancement New feature or request label Feb 11, 2025
@michelle0927 michelle0927 self-assigned this Feb 12, 2025
@michelle0927 michelle0927 moved this from Prioritized to Doing in Component (Source and Action) Backlog Feb 12, 2025
@michelle0927 michelle0927 linked a pull request Feb 12, 2025 that will close this issue
Open
@michelle0927 michelle0927 moved this from Doing to Ready for PR Review in Component (Source and Action) Backlog Feb 12, 2025
@vunguyenhung vunguyenhung added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Feb 13, 2025
@luancazarine luancazarine moved this from Ready for PR Review to In Review in Component (Source and Action) Backlog Feb 18, 2025
@luancazarine luancazarine moved this from In Review to Ready for QA in Component (Source and Action) Backlog Feb 18, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Feb 19, 2025
@vunguyenhung vunguyenhung moved this from In QA to Ready for QA in Component (Source and Action) Backlog Feb 19, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Feb 19, 2025
@vunguyenhung vunguyenhung moved this from In QA to Changes Required in Component (Source and Action) Backlog Feb 19, 2025
@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/Look-into-updating-Google-Ads-API-version-19ebf548bb5e81d993f5eec4b9e9f9c1

@michelle0927 michelle0927 moved this from Changes Required to Ready for QA in Component (Source and Action) Backlog Feb 19, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to Ready for Release in Component (Source and Action) Backlog Feb 20, 2025
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/Look-into-updating-Google-Ads-API-version-19ebf548bb5e81d993f5eec4b9e9f9c1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michelle0927 michelle0927

Labels
enhancement New feature or request triaged For maintainers: This issue has been triaged by a Pipedream employee
Projects
Component (Source and Action) Backlog
Status: Ready for Release
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Google Ads - update to api v18 PipedreamHQ/pipedream
3 participants
@michelle0927 @vunguyenhung @dannyroosevelt