Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP headers for propagating trace and span context #49

Open
stevapple opened this issue Mar 15, 2023 · 1 comment
Open

HTTP headers for propagating trace and span context #49

stevapple opened this issue Mar 15, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@stevapple
Copy link
Contributor

stevapple commented Mar 15, 2023

Is your feature request related to a problem? Please describe.
Trace and span context can be propagated through HTTP header(s). W3C has a recommended standard compatible with OpenTelemetry, while older Jaeger-compatible clients are using Uber's original format. If possible, we should support both:)

Describe the solution you'd like
Parse the HTTP headers accordingly and, if the content is valid, propagate the trace by overriding the default settings (trace id/parent span id/sampled/...).

Describe alternatives you've considered
Simply ignore it like what we're doing now. The full semantics is rather complex, so it may not worth the effort.

Additional context
https://www.w3.org/TR/trace-context-1/#trace-context-http-headers-format
https://www.jaegertracing.io/docs/1.22/client-libraries/#tracespan-identity

@stevapple stevapple added the enhancement New feature or request label Mar 15, 2023
@Pierre-Lannoy
Copy link
Owner

Hi @stevapple and thanks for this suggestion.
From my point of view, it could be done (and it's an interesting point) based on the W3C recommandation. Nevertheless I am a bit more sceptical about the Jaeger format… Let me think about it.
There is also one thing I don't quite understand about the W3C recommendations: do you see something about "trace poisoning"?

@Pierre-Lannoy Pierre-Lannoy added this to the DecaLog V4 - 4.0.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants