Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit logic when the twilio SmsAuthenticator is not REQUIRED #6

Open
bickelj opened this issue Feb 28, 2023 · 0 comments
Open

Revisit logic when the twilio SmsAuthenticator is not REQUIRED #6

bickelj opened this issue Feb 28, 2023 · 0 comments

Comments

@bickelj
Copy link
Contributor

bickelj commented Feb 28, 2023

See #3 (comment)

There are branches in the SmsAuthenticator.action() method that may not account for the condition of not being required, e.g. like this branch does:

if (execution.isConditional() || execution.isAlternative()) {
    context.attempted();
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant