-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up linting #4
Comments
Things still needed for a CI/CD pipeline for
At a higher level:
|
The result of this rearrangement: * Gradle at the top-level (`auth`) * A `twilio-keycloak-provider` module with its own build script. * A `pdc-keycloak-theme` module with its own build script. * An expected directory structure for `pdc-keycloak-theme`. To build a submodule, `cd [module name]` and then `../gradlew [task]`. Keycloak is Apache License 2.0 so the theme keeps that license. The SMS Authenticator was originally Expat (MIT) so it keeps Expat. Issue #4 Set up CI Issue #7 Theme the user-facing Keycloak pages
That's a comprehensive list; thanks, @bickelj! I was imagining that this issue would only be for tracking work on CI, and not on CD - that is, running tests and linting, and not versioning and publishing! In case that helps this feel less overwhelming. 😃 |
@jasonaowen Suppose we repurpose/rename this one to adding linting since the test run workflows (admittedly perhaps inappropriately) pushed with #3 and create the others by name as well? |
Yes, I had imagined linting as being a part of this, but I should have more explicitly said so! |
We should set up CI to run unit tests and a linter.
Part of this is deciding on a style guide for our linter. It's been a few years, but I think the most recent CheckStyle configuration I used was on the PSM: https://github.com/SolutionGuidance/psm/blob/master/psm-app/checkstyle.xml . I think my opinions on Java style are less strongly held now than they were then, though, so maybe we should just use the Google configuration?
This Stack Overflow answer shows how to configure CheckStyle with Google checks in Gradle.
The text was updated successfully, but these errors were encountered: