Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out-of-source Configure succeeds when it fails #56

Open
tonycoz opened this issue Jan 2, 2019 · 0 comments
Open

out-of-source Configure succeeds when it fails #56

tonycoz opened this issue Jan 2, 2019 · 0 comments

Comments

@tonycoz
Copy link
Contributor

tonycoz commented Jan 2, 2019

Based on Perl/perl5#16725

Perl's Configure has a mechanism to do out of source builds (-Dmksymlinks) but if the user tries to do such a build without that option, Configure produces an error message:

Run make depend now? [y]  
make: *** No rule to make target 'Makefile.SH', needed by 'Makefile'.  Stop.
...

but $? reports success:

tony@mars:.../git/outoftree$ echo $?
0

From going over the metaconfig source this could be fixed in dist/U/Finish.U, but to be friendlier it should also produce a message mentioning -Dmksymlinks, and I'm not sure if that belongs in dist/U/Finish.U

Ideally we'd detect an out-of-source build earlier and either:

a) report an error earlier, and exit 1 so calling tools do the right thing

b) automatically turn on -Dmksymlinks (though this can have unfriendly effects too)

@tonycoz tonycoz changed the title out-of-source Configure succeeds when i fails out-of-source Configure succeeds when it fails Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant