Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go embed for migrations #763

Open
lelvisl opened this issue Apr 18, 2022 · 2 comments
Open

Use go embed for migrations #763

lelvisl opened this issue Apr 18, 2022 · 2 comments

Comments

@lelvisl
Copy link

lelvisl commented Apr 18, 2022

Hi!
Thanks for your app!

Can you use embed(go 1.16 feature) for packing migration into the binary?
(I can make a PR with this change).
@lelvisl
Copy link
Author

lelvisl commented Aug 25, 2022

@nirbenrey please look

@nirbenrey
Copy link
Contributor

Hi @lelvisl,
Please open a PR with the required changes, and we will review it.
Thanks
Nir

lelvisl added a commit to lelvisl/service-manager that referenced this issue Sep 22, 2022
@lelvisl @devopsbot-mts
using go1.16 embed for sql migrations
6b30e97 
Peripli#763
@lelvisl lelvisl mentioned this issue Sep 22, 2022
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lelvisl @nirbenrey