Skip to content

Convert SIPNET compile-time flags to run-time options #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alomir opened this issue May 27, 2025 · 1 comment
Open

Convert SIPNET compile-time flags to run-time options #78

Alomir opened this issue May 27, 2025 · 1 comment
Assignees

Comments

@Alomir
Copy link
Collaborator

Alomir commented May 27, 2025

Once Decide on fate of compiler switches is complete, update SIPNET:

  • Flags slated for removal: remove flag and all related code
  • Flags slated for "always on": remove flag and all "flag off" code branches
  • Flags slated to stay as options: convert to run-time options

For the flags that are being converted,

  • expand the existing command line option code to include them
  • add checks for exclusions and dependencies between options
  • expand sipnet.in handling to also handle the same set of options as config-file params; note that specifications at the command line override those specified via file
  • (likely) add a context struct or the like to track all of the config that is specified; possibly add source of specification (file vs command) in there. We will eventually want to log that info.

See issue #72 for discussion of current compile flag exclusions and dependencies (but note that list may not be exhaustive).

PR #96 Covers the first part of the above, but is not enough to close this issue.

@dlebauer
Copy link
Member

dlebauer commented Jun 3, 2025

We've reached consensus in #71 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants