Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SysVnVPlan FT1-TC3 issue #22

Open
vajihehm opened this issue Oct 30, 2018 · 4 comments
Open

SysVnVPlan FT1-TC3 issue #22

vajihehm opened this issue Oct 30, 2018 · 4 comments

Comments

@vajihehm
Copy link

@PeaWagon
In “Test Input Geometry” It should be considered geometry values as you think purposefully bad or invalid. The example is not sufficient and you should specify a set of inputs as well as the output which is expected regarding to the given input.

2

@smiths
Copy link
Collaborator

smiths commented Oct 31, 2018

@PeaWagon, I agree with the feedback from @vajihehm - your test case should be more specific. If the Basic Set Exchange is a good resource, you should say specifically what you are going to use from it.

@smiths
Copy link
Collaborator

smiths commented Nov 6, 2018

@vajihehm, please do not add an additional number in your issues. GitHub already creates a number.

@vajihehm vajihehm changed the title SysVnVPlan FT1-TC3 issue #8 SysVnVPlan FT1-TC3 issue Nov 6, 2018
@vajihehm
Copy link
Author

vajihehm commented Nov 6, 2018

@smiths Sure. Edited.

@smiths
Copy link
Collaborator

smiths commented Nov 6, 2018

Thank you @vajihehm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants