Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name extraction #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix name extraction #67

wants to merge 1 commit into from

Conversation

apple-phi
Copy link

Closes #66

@PeWu
Copy link
Owner

PeWu commented Aug 12, 2024

Looks good. Thank you!

Do you think you could add the newly supported formats as test cases in tests/gedcom.spec.ts?

@apple-phi
Copy link
Author

@PeWu Sure, can do—but actually, now that I think about it, is there any reason to split out the forename and surname in the first place? Shouldn't topola just respect the ordering and naming of the individual, as given in the file? Because GEDCOM is designed to be flexible and allow all name orderings and conventions, whatever that might be in the individual's culture.

Because I've realised that if I get this PR merged, I'll soon probably have to make a PR to let the user choose the name ordering, but this seems like reinventing the wheel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix surname extraction
2 participants