Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topbar-fixed is not compatible with the new page layout #367

Open
stepandersen opened this issue May 16, 2019 · 1 comment
Open

topbar-fixed is not compatible with the new page layout #367

stepandersen opened this issue May 16, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@stepandersen
Copy link

With this markup:

<div class="container-fluid">
    <div class="row">
        <header class="topbar">Topbar component...</header>
    </div>
    <div class="row">
        <div class="col-auto">Sidebar component...</div>
        <main class="col main-content border-left">Main content things...</main>
    </div>
</div>

This rule doesn't apply anymore:

.topbar.topbar-fixed+* {
    margin-top: 70px;
}

I'm not sure what the best solution is, I added a custom class to the second class="row" and gave that a margin-top.

@Akswii
Copy link
Contributor

Akswii commented May 20, 2019

If you want a fixed full-width .topbar you can move the topbar outside of the container. We will consider making changes to how the .topbar works to make the markup consistent and improve the examples.

@Akswii Akswii added the enhancement New feature or request label May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants