Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic hub names #112

Open
IohannesIohannium opened this issue Jul 1, 2022 · 1 comment
Open

Dynamic hub names #112

IohannesIohannium opened this issue Jul 1, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@IohannesIohannium
Copy link
Contributor

Such a feature does not seem supported yet in-game, but we may override the locs of the hub names.

A configurable would be used as such:
link = { state = STATE_ISTRIA homeland = croatian city = "Trst" mine = "Željezograd" farm = "Opatija" wood = "Šuma" port = "Pula" }

In this case, if Istria is a homeland state for the Croatian ethnicity, the hub names are thus overwritten.
The first matching rule would be applied. All fields except for state and homeland are optional. If such fields are missing, no output is produced.

The overriding would be output in /localization/[language]/hub_names_l_[language].yml (for each language), with this syntax:
HUB_NAME_[State key]_[Field key]:1 "[String]"

As an example, HUB_NAME_STATE_ISTRIA_CITY:1 "Trst".

It'd be best to eventually move to nested locs for this configurable, so that dynamic names are correctly translated.

@Zemurin
Copy link
Member

Zemurin commented Apr 26, 2023

Eu4 more often than not provides province names, not city names, along with their respective dynamic names according to owner culture. Also due to map deformation, we can't guarantee the city in eu4 maps to the city in Vic3, making crossmapping from EU4 difficult.

I'll leave this issue open but I don't see a trivial way to rename base hubs using eu4 sources. Also, as noted, any rename would be permanent as there is no dynamic rename system in Vic3 yet.

@Zemurin Zemurin added the enhancement New feature or request label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants