Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Emoji dialog closes when another user adds a reaction #7621

Closed
Dschoordsch opened this issue Jan 5, 2023 · 12 comments
Closed

Discussion: Emoji dialog closes when another user adds a reaction #7621

Dschoordsch opened this issue Jan 5, 2023 · 12 comments
Assignees
Labels
bug icebox p3 Should be addressed when able

Comments

@Dschoordsch
Copy link
Contributor

Dschoordsch commented Jan 5, 2023

How to reproduce

Adam and Bertram participate in a Check-In in the agenda discussion with one comment without reactions. Adam opens the emoji dialog. While the dialog is open, Bertram adds a reaction to the same comment.

Expected behaviour

The dialog stays open and Adam can continue adding their reaction.

Actual behaviour

The dialog closes and Adam has to open it again

Comment

This probably happens because the button switches position, so it's probably a newly mounted component. This means the dialog should move up the component tree.

EE: 4h

@Dschoordsch Dschoordsch added bug p3 Should be addressed when able labels Jan 5, 2023
@bahdcoder
Copy link

hey @Dschoordsch how are you?

I would love to explore this ticket. Is it possible to tackle bugs as an outside contributor? It's not listed as part of the EFE tickets, but is a great place to start exploring the codebase.

Please let me know. Thanks 🤝 .

@Dschoordsch
Copy link
Contributor Author

I think that's a great idea. As this is a P3 it's unlikely we pick it up soon, so outside contributions are more than welcome. @jordanh any objections?

@Dschoordsch Dschoordsch removed their assignment Jan 10, 2023
@github-project-automation github-project-automation bot moved this to To Prioritize in Sprint Board Beta Jan 17, 2023
@jordanh
Copy link
Contributor

jordanh commented Jan 17, 2023

Thank you @Dschoordsch for the mention!

@bahdcoder yes, I place this one in our E4E program and assign you as the owner. Recently we've had a relatively high "abandon" rate for E4E work. In the past, we would execute a contract straight away that would make it clear that you're performing this work under E4E and would accrue points under that program. That costs us operations/lawyer time on our side and I'd like to make sure you're make it to the finish line on your first issue before we go through the trouble to put paper in place.

Could you let us know when you're ready to open a PR for review and then we'll send you a contract to review for the work?

@jordanh jordanh assigned bahdcoder and unassigned jordanh Jan 17, 2023
@Dschoordsch Dschoordsch removed their assignment Jan 18, 2023
@jordanh
Copy link
Contributor

jordanh commented Feb 28, 2023

@bahdcoder out of curiosity, are you still working on this issue or would it be ok for us to reassign it?

@Narcos101
Copy link

hey @jordanh If he isn't responding please assign this issue to me. I would try to take a shot at it!

@jordanh
Copy link
Contributor

jordanh commented Apr 11, 2023

@Narcos101 please go ahead an take a shot at it!

@Narcos101
Copy link

@Dschoordsch Do you have a discord or a slack id so that i can ask doubts to you?

@jordanh jordanh added this to Product Mar 15, 2024
@github-project-automation github-project-automation bot moved this to To triage in Product Mar 15, 2024
@Mohd-Muneeb
Copy link
Contributor

Mohd-Muneeb commented Apr 8, 2024

Hey there, if the issue is still active and if @Narcos101 is okay with it, can I pick this up?

@Dschoordsch
Copy link
Contributor Author

There was no activity for a long time, feel free to pick this one up.

@Mohd-Muneeb
Copy link
Contributor

Cool. Thank you!

@jordanh jordanh moved this from To triage to Backlog in Product May 7, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Stale issue

@github-actions github-actions bot added the stale label Oct 8, 2024
@jordanh
Copy link
Contributor

jordanh commented Jan 9, 2025

Iceboxing for now.

@jordanh jordanh added icebox and removed stale labels Jan 9, 2025
@jordanh jordanh closed this as completed Jan 9, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Product Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug icebox p3 Should be addressed when able
Projects
Status: Done
Status: Done
Status: To Prioritize
Status: No status
Development

No branches or pull requests

6 participants