Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retro phase instruction text #10072

Open
Dschoordsch opened this issue Aug 5, 2024 · 6 comments
Open

Fix retro phase instruction text #10072

Dschoordsch opened this issue Aug 5, 2024 · 6 comments
Labels
bug p2 Needs to be addressed on a reasonable timescale

Comments

@Dschoordsch
Copy link
Contributor

The tooltips don't take into account some settings and show wrong text:

  • retro reflection phase always says it's anonymous
  • retro voting phase does not take current vote settings into account
@Dschoordsch Dschoordsch added bug p3 Should be addressed when able labels Aug 5, 2024
@jordanh jordanh added this to Product Aug 21, 2024
@github-project-automation github-project-automation bot moved this to To triage in Product Aug 21, 2024
@jordanh jordanh moved this from To triage to Backlog in Product Aug 21, 2024
@jordanh jordanh moved this from Backlog to To triage in Product Aug 21, 2024
@jordanh jordanh moved this from Ready to To triage in Product Jan 13, 2025
@jordanh jordanh moved this from To triage to Backlog in Product Jan 13, 2025
Copy link
Contributor

github-actions bot commented Feb 2, 2025

Stale issue

@github-actions github-actions bot added the stale label Feb 2, 2025
@iamhks
Copy link
Contributor

iamhks commented Feb 16, 2025

Image

Attached screenshot, I don't think this issue exists anymore.
While scheduling the meeting if Anonymous reflections is unchecked then the user's name shows up in the Reflection phase. Also the vote settings are working as expected.

@jordanh jordanh changed the title Fix retro tooltips Fix retro phase instruction text Feb 17, 2025
@jordanh jordanh removed the stale label Feb 17, 2025
@jordanh
Copy link
Contributor

jordanh commented Feb 17, 2025

Turns out, @Dschoordsch was talking about the copy that describes each phase. I'll prioritize this a bit higher.

@jordanh jordanh moved this from Backlog to To triage in Product Feb 17, 2025
@jordanh jordanh added p2 Needs to be addressed on a reasonable timescale and removed p3 Should be addressed when able labels Feb 17, 2025
@Dschoordsch
Copy link
Contributor Author

To be clear, I meant the "Tips" button in the toolbar

Image

@iamhks
Copy link
Contributor

iamhks commented Feb 18, 2025

So there are 2 ways to fix this:

  • We can pass the current vote settings as a prop to VoteHelpMenu.tsx and render the component accordingly.
  • We update the static text simply to Each teammate gets a set number of votes, determined by the team admin. The maximum votes per group are also defined in the vote settings above.

@Dschoordsch
Copy link
Contributor Author

We should do a dynamic text. The stageRef is already passed to the help component. You can check

and how it's used for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug p2 Needs to be addressed on a reasonable timescale
Projects
Status: To triage
Development

No branches or pull requests

3 participants