Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

Python 3 support in panos_admpwd #192

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

fvigo
Copy link
Contributor

@fvigo fvigo commented Nov 12, 2018

Support Python 3 in panos_admpwd, previously fails with TypeError as recv() in Python 3 returns bytes and not str

Support Python 3 in panos_admpwd, previously fails with TypeError as recv() in Python 3 returns bytes and not str
Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shinmog
Copy link
Collaborator

shinmog commented Feb 11, 2020

@fvigo

If you would, could you open a new PR against the collection's develop with this fix?

https://github.com/PaloAltoNetworks/pan-os-ansible

@fvigo fvigo changed the base branch from master to develop February 28, 2020 14:17
@fvigo
Copy link
Contributor Author

fvigo commented Feb 28, 2020

@shinmog changed the base, let me know if that works! Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants